Re: [PATCH v5 4/8] char: rpmb: provide a user space interface
From: Pavel Machek <hidden>
Date: 2016-08-05 20:08:34
Also in:
linux-scsi, lkml
From: Pavel Machek <hidden>
Date: 2016-08-05 20:08:34
Also in:
linux-scsi, lkml
On Mon 2016-07-18 23:27:49, Tomas Winkler wrote:
The user space API is achieved via two synchronous IOCTL.
IOCTLs?
Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is performed by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD where the whole RPMB sequence including RESULT_READ is supplied by the caller. The latter is intended for easier adjusting of the applications that use MMC_IOC_MULTI_CMD ioctl.
Why " "?
Signed-off-by: Tomas Winkler <redacted>
+
+static long rpmb_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
+{
+ return __rpmb_ioctl(fp, cmd, (void __user *)arg);
+}
+
+#ifdef CONFIG_COMPAT
+static long rpmb_compat_ioctl(struct file *fp, unsigned int cmd,
+ unsigned long arg)
+{
+ return __rpmb_ioctl(fp, cmd, compat_ptr(arg));
+}
+#endif /* CONFIG_COMPAT */Description of the ioctl is missing, and it should certainly be designed in a way that it does not need compat support. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html