On Mon, Feb 17, 2014 at 11:03:02AM +0100, David Lanzendörfer wrote:

Please use the real compatibles here. It's much easier to search
for. Plus, your driver doesn't support all the SoCs you're mentionning here.

+- base registers are 0x1000 appart, so the base of mmc1
+  would be 0x01c0f000+0x1000=0x01c10000(see example)
+  and so on.

Please provide the real property name to use. No need for an example
here, you have a full-fledged one in a few lines.

+- clocks requires the reference at the ahb clock gate
+  with the correct index (mmc0 -> 8, mmc1 -> 9, and so on)
+  as well as the reference to the correct mod0 clock.

Ditto. Plus, this is not a mod0 clock.

+- interrupts requires the correct IRQ line
+  (mmc0 -> 32, mmc1 -> 33, and so on)

Ditto.

+
+Examples:
+
+mmc0: mmc@01c0f000 {
+	compatible = "allwinner,sun5i-a13-mmc";
+	reg = <0x01c0f000 0x1000>;
+	clocks = <&ahb_gates 8>, <&mmc0_clk>;
+	clock-names = "ahb", "mod";

You never talked about the clock-names property, and which clocks were
supposed to be provided.

+	interrupts = <0 32 4>;
+	bus-width = <4>;

And you never talked about bus-width either.

+	status = "disabled";
+};

Isn't the cd-gpios property requested too?

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com