Re: [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value

2012/12/5 Mark Brown [off-list ref]

On Tue, Dec 04, 2012 at 10:50:03PM +0800, Kevin Liu wrote:

quoted

2012/12/4 Marek Szyprowski [off-list ref]:

quoted

quoted

+       if (host->vmmc && regulator_get_voltage(host->vmmc) > 0) {
                ret = regulator_is_supported_voltage(host->vmmc,
2700000,
                        3600000);
                if ((ret <= 0) || (!(caps[0] & SDHCI_CAN_VDD_330)))

quoted

Good idea. But how about the regulator is disabled at this point? So I
suggest to change to
     if (host->vmmc && regulator_get_voltage(host->vmmc) >= 0)

I'd not expect regulator_get_voltage() to return 0 for disabled
regulators, I'd expect it to return the voltage the regulator will have
when enabled.

Understand.

Thanks
Kevin