On Tue, 2012-10-23 at 23:49 +0100, Grant Likely wrote:

quoted

+enum dmaengine_apis {
+       DMAENGINE_MEMCPY        = 0x0001,
+       DMAENGINE_XOR           = 0x0002,
+       DMAENGINE_XOR_VAL       = 0x0004,
+       DMAENGINE_PQ            = 0x0008,
+       DMAENGINE_PQ_VAL        = 0x0010,
+       DMAENGINE_MEMSET        = 0x0020,
+       DMAENGINE_SLAVE         = 0x0040,
+       DMAENGINE_CYCLIC        = 0x0080,
+       DMAENGINE_INTERLEAVED   = 0x0100,
+       DMAENGINE_SG            = 0x0200,
+};

Actually, one more comment. Why the new enum? Why can't the
dma_transaction_type enum be used directly along with dma_cap_mask_t? 

Some of the capabilities above are not there in dma_caps_t like DMA_SG.
Also DMA_INTERRUPT and DMA_PRIVATE would not make much sense here.

BUT would help to keep things simpler if have one definition which
includes all.
 
-- 
Vinod Koul
Intel Corp.