Re: [PATCH 1/2] ARM: dt: tegra: Add sdhci regulators
From: Marc Dietrich <hidden>
Date: 2012-10-23 18:08:28
Also in:
linux-arm-kernel, linux-tegra, lkml
Pavan, On Tuesday 23 October 2012 12:48:59 Pavan Kunapuli wrote:
Adding vmmc and vmmcq supplies for sdhci nodes in tegra dt files.
<...>
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/tegra20-paz00.dtsb/arch/arm/boot/dts/tegra20-paz00.dts index 6a93d14..e161b65 100644--- a/arch/arm/boot/dts/tegra20-paz00.dts +++ b/arch/arm/boot/dts/tegra20-paz00.dts@@ -422,13 +422,17 @@ status = "okay"; cd-gpios = <&gpio 173 0>; /* gpio PV5 */ wp-gpios = <&gpio 57 0>; /* gpio PH1 */ - power-gpios = <&gpio 169 0>; /* gpio PV1 */ bus-width = <4>; + vmmc-supply = <&vddio_sd_reg>; + vqmmc-supply = <&vddio_sd_reg>; }; sdhci@c8000600 { status = "okay"; bus-width = <8>; + vmmc-supply = <&vddio_sdmmc_reg>; + vqmmc-supply = <&vddio_sdmmc_reg>;
to make it better, this should be: vmmc-supply = <&vcore_mmc_reg>; and vqmmc-supply = <&vddio_nand_reg>; with vcore_mmc_reg is ldo5 and vddio_nand_reg is the fixed regulator below. By doing so, I get "sdhci-tegra sdhci-tegra.3: could not set regulator OCR (-1)". MMC subsys wants to set ldo5 to 3.3V but it is fixed. I guess that's harmless for now.
quoted hunk ↗ jump to hunk
}; gpio-keys {@@ -465,6 +469,24 @@ regulator-max-microvolt = <5000000>; regulator-always-on; }; + + vddio_sd_reg: regulator@1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "vddio_sd"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&gpio 169 0>; /* gpio PV1 */ + }; + + vddio_sdmmc_reg: regulator@2 {
^^ vddio_nand_reg acording to schematics
+ compatible = "regulator-fixed"; + reg = <2>; + regulator-name = "vddio_sdmmc";
also here
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
};
sound {