RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc
From: Zang Roy-R61911 <hidden>
Date: 2011-08-15 04:46:34
Also in:
linuxppc-dev
From: Zang Roy-R61911 <hidden>
Date: 2011-08-15 04:46:34
Also in:
linuxppc-dev
-----Original Message----- From: Anton Vorontsov [mailto:cbouatmailru@gmail.com] Sent: Friday, August 12, 2011 18:05 PM To: Zang Roy-R61911 Cc: linux-mmc@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; akpm@linux- foundation.org; Xu Lei-B33228; Kumar Gala; Wood Scott-B07421 Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc Hello, On Fri, Aug 12, 2011 at 09:44:26AM +0000, Zang Roy-R61911 wrote: [...]quoted
quoted
We try to not pollute generic sdhci.c driver with chip-specific quirks. Maybe you can do the fixups via IO accessors? Or by introducing some additional sdhci op?Anton, thanks for the comment, as we discussed, the original code use 8 bit byteoperation,quoted
while in fact, on some powerpc platform, 32 bit operation is needed. should it be possible fixed by adding some wrapper in IO accessors orintroduce additional sdhci op? I would do it in the IO accessors.
I am looking forward to your patch. Roy