Re: [PATCH v7 1/3] mm: make persistent huge zero folio read-only

On Thu, Sep 3, 2026 at 4:59 AM Dave Hansen [off-list ref] wrote:

On 9/1/26 08:18, Xueyuan Chen wrote:

quoted

+static inline int set_direct_map_ro(struct page *page, unsigned int nr)
+{
+     return 0;
+}

I still really think the stub here needs to return an error *or* the
thing needs to just be void and tell folks that they can't know whether
it worked or not.

Hi Dave,

I kept the stub returning 0 for consistency with the other
set_direct_map*() stubs, which also return 0.

But returning -ENOSYS or -ENODEV works for me too if you prefer that.

Thanks,
Xueyuan