On Thu, Feb 23, 2023 at 04:01:54PM -0800, Minchan Kim wrote:

Hi Hyeonggon

Hi Minchan.

On Mon, Feb 20, 2023 at 01:21:53PM +0000, Hyeonggon Yoo wrote:

quoted

[Maybe not the best time to send patch series, but just wanted to
 get some early feedback from zsmalloc maintainers]

The purpose of this series is to define own memory descriptor for zsmalloc,
instead of re-using various fields of struct page. This is a part of the
effort to reduce the size of struct page to unsigned long and enable
dynamic allocation of memory descriptors.

While [1] outlines this ultimate objective, the current use of struct page
is highly interdependent, making it challenging to separately allocate
memory descriptors.

Therefore, this series introduces new descriptor for zsmalloc, called
zsdesc. It overlays struct page for now, but will eventually be allocated
independently in the future. And apart from dynamic allocation of descriptors,
this is a nice cleanup.

I have no strong opinion about its name. I was thinking about between
zsmem and zsdesc, and wanted to be consistent with struct ptdesc.
(which is AFAIK work in progress)

I wanted to have the chance to take a look zsmalloc folio stuff but
couldn't set up some time. :( Thanks for the good work, Hyeonggon!

My pleasure :)

I will take a look once when I am available.
Just FYI, Sergey was doing some changes in zsmalloc
https://lore.kernel.org/linux-mm/20230223030451.543162-1-senozhatsky@chromium.org/ (local)
I guess this patch would conflict with it so may need to rebase
once they were merged.

Sure. I'll rebase as they are already in mm-unstable.

Anyway, Regardless of that, I will review
this patch as soon as finishing urgent stuff.

No problem, thank you so much!

Thanks.