Thread (143 messages) 143 messages, 23 authors, 2022-12-21

Re: [PATCH 4/4] mm: delay page_remove_rmap() until after the TLB has been flushed

From: Nadav Amit <hidden>
Date: 2022-11-08 21:05:47
Also in: lkml

On Nov 8, 2022, at 11:41 AM, Linus Torvalds [off-list ref] wrote:
When we remove a page table entry, we are very careful to only free the
page after we have flushed the TLB, because other CPUs could still be
using the page through stale TLB entries until after the flush.
The patches (all 4) look fine to me.

I mean there are minor issues here and there, like s390’s tlb_flush_rmaps()
that can have VM_WARN_ON(1);the generic tlb_flush_rmaps() that is missing an
empty line after the ‘page' variable definition; or perhaps using __bitwise
for sparse (as David pointed) — but it can all be addressed later.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help