Thread (26 messages) 26 messages, 3 authors, 2021-11-19
STALE1653d REVIEWED: 1 (0M)

[PATCH v5 5/8] device-dax: use ALIGN() for determining pgoff

From: Joao Martins <hidden>
Date: 2021-11-12 15:09:36
Also in: linux-doc, nvdimm
Subsystem: device direct access (dax), the rest · Maintainers: Dan Williams, Vishal Verma, Dave Jiang, Linus Torvalds

Rather than calculating @pgoff manually, switch to ALIGN() instead.

Suggested-by: Dan Williams <redacted>
Signed-off-by: Joao Martins <redacted>
Reviewed-by: Dan Williams <redacted>
---
 drivers/dax/device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index dd8222a42808..0b82159b3564 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -234,8 +234,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf,
 		 * mapped. No need to consider the zero page, or racing
 		 * conflicting mappings.
 		 */
-		pgoff = linear_page_index(vmf->vma, vmf->address
-				& ~(fault_size - 1));
+		pgoff = linear_page_index(vmf->vma,
+				ALIGN(vmf->address, fault_size));
 		for (i = 0; i < fault_size / PAGE_SIZE; i++) {
 			struct page *page;
 
-- 
2.17.2

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help