Re: [PATCH v3 2/4] mm/oom: handle remote ooms
From: Michal Hocko <mhocko@suse.com>
Date: 2021-11-12 07:52:03
Also in:
cgroups, linux-fsdevel
From: Michal Hocko <mhocko@suse.com>
Date: 2021-11-12 07:52:03
Also in:
cgroups, linux-fsdevel
On Thu 11-11-21 15:42:01, Mina Almasry wrote:
On remote ooms (OOMs due to remote charging), the oom-killer will attempt to find a task to kill in the memcg under oom, if the oom-killer is unable to find one, the oom-killer should simply return ENOMEM to the allocating process.
This really begs for some justification.
If we're in pagefault path and we're unable to return ENOMEM to the allocating process, we instead kill the allocating process.
Why do you handle those differently?
Signed-off-by: Mina Almasry <redacted> Cc: Michal Hocko <mhocko@suse.com> Cc: Theodore Ts'o <tytso@mit.edu> Cc: Greg Thelen <redacted> Cc: Shakeel Butt <redacted> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Hugh Dickins <hughd@google.com> CC: Roman Gushchin <redacted> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Hugh Dickins <hughd@google.com> Cc: Tejun Heo <tj@kernel.org> Cc: Vladimir Davydov <redacted> Cc: Muchun Song <redacted> Cc: riel@surriel.com Cc: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org Cc: cgroups@vger.kernel.org
-- Michal Hocko SUSE Labs