Re: [PATCH] mm: Use BUG_ON instead of if condition followed by BUG
From: David Hildenbrand <hidden>
Date: 2021-11-24 11:10:58
Also in:
lkml
On 24.11.21 04:08, cgel.zte@gmail.com wrote:
From: chiminghao <redacted>
"mm/memory_hotplug: Use BUG_ON instead of if condition followed by BUG" Would be better
quoted hunk ↗ jump to hunk
Fix the following coccinelle report: ./mm/memory_hotplug.c:2210:2-5: WARNING Use BUG_ON instead of if condition followed by BUG. Reported-by: Zeal Robot <redacted> Signed-off-by: chiminghao <redacted> --- mm/memory_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 3de7933e5302..aecb12bb7513 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c@@ -2212,8 +2212,7 @@ void __remove_memory(u64 start, u64 size) * trigger BUG() if some memory is not offlined prior to calling this * function */ - if (try_remove_memory(start, size)) - BUG(); + BUG_ON(try_remove_memory(start, size)); } /*
Acked-by: David Hildenbrand <redacted> -- Thanks, David / dhildenb