Re: [PATCH] dax: Kill DEV_DAX_PMEM_COMPAT
From: Jane Chu <hidden>
Date: 2021-10-30 03:54:50
Also in:
nvdimm
On 10/29/2021 6:44 PM, Dan Williams wrote:
On Fri, Oct 29, 2021 at 5:19 PM Jane Chu [off-list ref] wrote:quoted
Hi, Dan, I think we're still using _COMPAT, but likely don't need to.Ugh, really? I hope not, that would be unfortunate. Perhaps are you using libndctl / libdaxctl rather than going to /sys/class/dax directly? Those have shipped backwards compatibility for a while now, so applications using those libraries should not notice the switch to the /sys/bus/dax ABI. The only other open source application I could find that had /sys/class/dax dependencies was fio, but I fixed that up years ago as well.
Yup, we use libndctl / libdaxctl, so the removal likely is okay.
> What is your patch based on? This is based on a branch I have with Christoph's recent dax reworks. I have a test merge of that pushed out on my libnvdimm-pending branch if you want to give it a try. https://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm.git/log/?h=libnvdimm-pending
Got it, thanks! -jane