Re: [v5 PATCH 3/6] mm: filemap: coding style cleanup for filemap_map_pmd()
From: Joe Perches <joe@perches.com>
Date: 2021-10-21 06:19:13
Also in:
linux-fsdevel, lkml
On Wed, 2021-10-20 at 14:07 -0700, Yang Shi wrote:
A minor cleanup to the indent.
[]
quoted hunk ↗ jump to hunk
diff --git a/mm/filemap.c b/mm/filemap.c
[]
quoted hunk ↗ jump to hunk
@@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) } if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { - vm_fault_t ret = do_set_pmd(vmf, page); - if (!ret) { - /* The page is mapped successfully, reference consumed. */ - unlock_page(page); - return true; - } + vm_fault_t ret = do_set_pmd(vmf, page); + if (!ret) { + /* The page is mapped successfully, reference consumed. */ + unlock_page(page); + return true; + }
It might be more preferred to add a blank line after the automatic when touching this block.