Re: [PATCH] userfaultfd/selftests: use swap() to make code cleaner
From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-10-28 13:13:48
Also in:
linux-kselftest, lkml
On 10/28/21 5:23 AM, cgel.zte@gmail.com wrote:
From: Changcheng Deng <redacted> Use swap() in order to make code cleaner. Issue found by coccinelle.
Please include the coccinelle log.
quoted hunk ↗ jump to hunk
Reported-by: Zeal Robot <redacted> Signed-off-by: Changcheng Deng <redacted> --- tools/testing/selftests/vm/userfaultfd.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c index 8a09057d2f22..41dfe6f4ebfb 100644 --- a/tools/testing/selftests/vm/userfaultfd.c +++ b/tools/testing/selftests/vm/userfaultfd.c@@ -1413,7 +1413,6 @@ static void userfaultfd_pagemap_test(unsigned int test_pgsize) static int userfaultfd_stress(void) { void *area; - char *tmp_area; unsigned long nr; struct uffdio_register uffdio_register; struct uffd_stats uffd_stats[nr_cpus];@@ -1524,13 +1523,8 @@ static int userfaultfd_stress(void) count_verify[nr], nr); /* prepare next bounce */ - tmp_area = area_src; - area_src = area_dst; - area_dst = tmp_area; - - tmp_area = area_src_alias; - area_src_alias = area_dst_alias; - area_dst_alias = tmp_area; + swap(area_src, area_dst); + swap(area_src_alias, area_dst_alias); uffd_stats_report(uffd_stats, nr_cpus); }
thanks, -- Shuah