Thread (5 messages) 5 messages, 5 authors, 2021-10-27

Re: [PATCH] hugetlb: remove unnecessary set_page_count in prep_compound_gigantic_page

From: Pasha Tatashin <pasha.tatashin@soleen.com>
Date: 2021-10-26 22:23:26
Also in: lkml

On Tue, Oct 26, 2021 at 6:06 PM Mike Kravetz [off-list ref] wrote:
In commit 7118fc2906e29 ("hugetlb: address ref count racing in
prep_compound_gigantic_page"), page_ref_freeze is used to atomically
zero the ref count of tail pages iff they are 1.  The unconditional
call to set_page_count(0) was left in the code.  This call is after
page_ref_freeze so it is really a noop.

Remove redundant and unnecessary set_page_count call.

Fixes: 7118fc2906e29 ("hugetlb: address ref count racing in prep_compound_gigantic_page")
Suggested-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: Mike Kravetz <redacted>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>

Thanks,
Pasha
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help