Thread (9 messages) 9 messages, 3 authors, 2021-09-02
STALE1761d
Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 3/5] mm/page_alloc.c: fix obsolete comment in free_pcppages_bulk()

From: Miaohe Lin <linmiaohe@huawei.com>
Date: 2021-09-02 12:12:36
Also in: lkml
Subsystem: memory management, memory management - page allocator, the rest · Maintainers: Andrew Morton, Vlastimil Babka, Linus Torvalds

The second two paragraphs about "all pages pinned" and pages_scanned is
obsolete. And There are PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP orders
in pcp. So the same order assumption is not held now.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/page_alloc.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index d3983244f56f..f7fcbac2d091 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1426,14 +1426,8 @@ static inline void prefetch_buddy(struct page *page)
 
 /*
  * Frees a number of pages from the PCP lists
- * Assumes all pages on list are in same zone, and of same order.
+ * Assumes all pages on list are in same zone.
  * count is the number of pages to free.
- *
- * If the zone was previously in an "all pages pinned" state then look to
- * see if this freeing clears that state.
- *
- * And clear the zone's pages_scanned counter, to hold off the "all pages are
- * pinned" detection logic.
  */
 static void free_pcppages_bulk(struct zone *zone, int count,
 					struct per_cpu_pages *pcp)
-- 
2.23.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help