Re: [PATCH v1 03/14] mm: add iomem vma selection for memory migration

From
Sierra Guiza, Alejandro (Alex) <hidden>
Date
2021-08-25 18:24:37
Also in
amd-gfx, dri-devel, linux-ext4, linux-xfs
Reply to
Christoph Hellwig, 2021-08-25
On 8/25/2021 2:46 AM, Christoph Hellwig wrote:
On Tue, Aug 24, 2021 at 10:48:17PM -0500, Alex Sierra wrote:
quoted
  		} else {
-			if (!(migrate->flags & MIGRATE_VMA_SELECT_SYSTEM))
+			if (!(migrate->flags & MIGRATE_VMA_SELECT_SYSTEM) &&
+			    !(migrate->flags & MIGRATE_VMA_SELECT_IOMEM))
  				goto next;
  			pfn = pte_pfn(pte);
  			if (is_zero_pfn(pfn)) {
.. also how is this going to work for the device public memory?  That
should be pte_special() an thus fail vm_normal_page.
Perhaps we're missing something, as we're not doing any special marking for the device public pfn/entries.
pfn_valid return true, pte_special return false and pfn_t_devmap return false on these pages. Same as system pages.
That's the reason vm_normal_page returns the page correctly through pfn_to_page helper.

Regards,
Alex S.
Thread (42 messages) 42 messages, 9 authors, last reply 2021-09-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help