Re: [PATCH v14 001/138] mm: Convert get_page_unless_zero() to return bool
From: David Howells <dhowells@redhat.com>
Date: 2021-08-10 15:27:17
Also in:
linux-fsdevel, lkml
From: David Howells <dhowells@redhat.com>
Date: 2021-08-10 15:27:17
Also in:
linux-fsdevel, lkml
Matthew Wilcox (Oracle) [off-list ref] wrote:
atomic_add_unless() returns bool, so remove the widening casts to int in page_ref_add_unless() and get_page_unless_zero(). This causes gcc to produce slightly larger code in isolate_migratepages_block(), but it's not clear that it's worse code. Net +19 bytes of text. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Acked-by: Kirill A. Shutemov <redacted>
Reviewed-by: David Howells <dhowells@redhat.com>