On Fri, Aug 27, 2021 at 01:07:59PM -0500, Brijesh Singh wrote:

Okay, works for me. The main reason why I choose the enum was to not
expose the GHCB exit code to the driver

Why does that matter?

but I guess that attestation driver need to know which VMGEXIT need to
be called, so, its okay to have it pass the VMGEXIT number instead of
enum.

Well, they're in an uapi header - can't be more public than that. :-)

So far most of the changes were in x86 specific files. However, the
attestation service is available through a driver to the userspace. The
driver needs to use the VMGEXIT routines provides by the x86 core. I
created the said header file so that driver does not need to include
<asm/sev.h/sev-common.h> etc and will compile for !x86.

Lemme ask my question again:

Is SNP available on something which is !x86, all of a sudden?

Why would you want to compile that driver on anything but x86?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette