Re: [PATCH for-next 16/25] fortify: Explicitly disable Clang support

From
Nick Desaulniers <ndesaulniers@google.com>
Date
2021-08-25 19:42:13
Also in
linux-hardening, lkml
Reply to
Kees Cook, 2021-08-22
On Sun, Aug 22, 2021 at 12:57 AM Kees Cook [off-list ref] wrote:
Clang has never correctly compiled the FORTIFY_SOURCE defenses due to
a couple bugs:

        Eliding inlines with matching __builtin_* names
        https://bugs.llvm.org/show_bug.cgi?id=50322

        Incorrect __builtin_constant_p() of some globals
        https://bugs.llvm.org/show_bug.cgi?id=41459

In the process of making improvements to the FORTIFY_SOURCE defenses, the
first (silent) bug (coincidentally) becomes worked around, but exposes
the latter which breaks the build. As such, Clang must not be used with
CONFIG_FORTIFY_SOURCE until at least latter bug is fixed (in Clang 13),
and the fortify routines have been rearranged.

Update the Kconfig to reflect the reality of the current situation.

Signed-off-by: Kees Cook <redacted>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
quoted hunk ↗ jump to hunk
---
 security/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/security/Kconfig b/security/Kconfig
index 0ced7fd33e4d..fe6c0395fa02 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -191,6 +191,9 @@ config HARDENED_USERCOPY_PAGESPAN
 config FORTIFY_SOURCE
        bool "Harden common str/mem functions against buffer overflows"
        depends on ARCH_HAS_FORTIFY_SOURCE
+       # https://bugs.llvm.org/show_bug.cgi?id=50322
+       # https://bugs.llvm.org/show_bug.cgi?id=41459
+       depends on !CC_IS_CLANG
        help
          Detect overflows of buffers in common string and memory functions
          where the compiler can determine and validate the buffer sizes.
--
2.30.2

--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210822075122.864511-17-keescook%40chromium.org.


-- 
Thanks,
~Nick Desaulniers
Thread (42 messages) 42 messages, 5 authors, last reply 2021-10-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help