[PATCH v2 53/61] mm/mlock: Use maple tree iterators instead of vma linked list
From: Liam Howlett <hidden>
Date: 2021-08-17 15:56:35
Also in:
lkml
Subsystem:
memory management, memory mapping, the rest · Maintainers:
Andrew Morton, Liam R. Howlett, Lorenzo Stoakes, Linus Torvalds
From: "Liam R. Howlett" <redacted> Signed-off-by: Liam R. Howlett <redacted> --- mm/mlock.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/mm/mlock.c b/mm/mlock.c
index e263d62ae2d0..a91ea32fb219 100644
--- a/mm/mlock.c
+++ b/mm/mlock.c@@ -563,6 +563,7 @@ static int apply_vma_lock_flags(unsigned long start, size_t len, unsigned long nstart, end, tmp; struct vm_area_struct *vma, *prev; int error; + MA_STATE(mas, ¤t->mm->mm_mt, start, start); VM_BUG_ON(offset_in_page(start)); VM_BUG_ON(len != PAGE_ALIGN(len));
@@ -571,11 +572,11 @@ static int apply_vma_lock_flags(unsigned long start, size_t len, return -EINVAL; if (end == start) return 0; - vma = find_vma(current->mm, start); - if (!vma || vma->vm_start > start) + vma = mas_walk(&mas); + if (!vma) return -ENOMEM; - prev = vma->vm_prev; + prev = mas_prev(&mas, 0); if (start > vma->vm_start) prev = vma;
@@ -597,7 +598,7 @@ static int apply_vma_lock_flags(unsigned long start, size_t len, if (nstart >= end) break; - vma = prev->vm_next; + vma = vma_next(prev->vm_mm, prev); if (!vma || vma->vm_start != nstart) { error = -ENOMEM; break;
@@ -618,15 +619,13 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm, { struct vm_area_struct *vma; unsigned long count = 0; + MA_STATE(mas, &mm->mm_mt, start, start); if (mm == NULL) mm = current->mm; - vma = find_vma(mm, start); - if (vma == NULL) - return 0; - - for (; vma ; vma = vma->vm_next) { + rcu_read_lock(); + mas_for_each(&mas, vma, start + len) { if (start >= vma->vm_end) continue; if (start + len <= vma->vm_start)
@@ -641,6 +640,7 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm, count += vma->vm_end - vma->vm_start; } } + rcu_read_unlock(); return count >> PAGE_SHIFT; }
@@ -741,6 +741,7 @@ static int apply_mlockall_flags(int flags) { struct vm_area_struct *vma, *prev = NULL; vm_flags_t to_add = 0; + unsigned long addr = 0; current->mm->def_flags &= VM_LOCKED_CLEAR_MASK; if (flags & MCL_FUTURE) {
@@ -759,7 +760,7 @@ static int apply_mlockall_flags(int flags) to_add |= VM_LOCKONFAULT; } - for (vma = current->mm->mmap; vma ; vma = prev->vm_next) { + mt_for_each(¤t->mm->mm_mt, vma, addr, ULONG_MAX) { vm_flags_t newflags; newflags = vma->vm_flags & VM_LOCKED_CLEAR_MASK;
--
2.30.2