Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp
From: Matthew Wilcox <willy@infradead.org>
Date: 2021-08-03 11:38:51
Also in:
lkml
On Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote:
quoted hunk ↗ jump to hunk
+++ b/include/linux/rmap.h@@ -243,7 +243,7 @@ int page_mkclean(struct page *); */ void page_mlock(struct page *page); -void remove_migration_ptes(struct page *old, struct page *new, bool locked); +void remove_migration_ptes(struct page *old, struct page *new, bool locked, bool unmap_clean);
I'm not a big fan of 'bool, bool'. Could we use a flag word instead? #define MIGRATE_REMOVE_LOCKED 1 #define MIGRATE_UNMAP_CLEAN 2