On Sun 2021-08-01 20:49 -0700, David Rientjes wrote:

oom_score_adj is shown already in the tasklist dump, I'm not sure what 
value this adds.

Fair enough.

quoted

+	else if (test_bit(MMF_OOM_SKIP, &p->mm->flags)
+		return "R";
+	else if (in_vfork(p))
+		return "V";

This is going to be racy, we can't show that a task that is emitted as 
part of the tasklist dump was did not have in_vfork() == true at the time 
oom_badness() was called.

Yes, this is true.

Wouldn't it be better to simply print the output of oom_badness() to the 
tasklist dump instead so we get complete information?

I think this would be acceptable.

We could simply special case a LONG_MIN return value as -1000 or "min".

Agreed.





Kind regards,

-- 
Aaron Tomlin