Thread (3 messages) 3 messages, 3 authors, 2021-07-28

Re: [PATCH] mm/migrate: fix NR_ISOLATED corruption on 64-bit

From: David Hildenbrand <hidden>
Date: 2021-07-28 08:19:40

On 28.07.21 06:25, Aneesh Kumar K.V wrote:
quoted hunk ↗ jump to hunk
Similar to commit 2da9f6305f30 ("mm/vmscan: fix NR_ISOLATED_FILE corruption on 64-bit")
avoid using unsigned int for nr_pages. With unsigned int type the large
unsigned int converts to a large positive signed long.

Symptoms include CMA allocations hanging forever
due to alloc_contig_range->...->isolate_migratepages_block waiting
forever in "while (unlikely(too_many_isolated(pgdat)))".

Fixes: c5fc5c3ae0c8 ("mm: migrate: account THP NUMA migration counters correctly")
Cc: Yang Shi <redacted>
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Aneesh Kumar K.V <redacted>
---
  mm/migrate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 34a9ad3e0a4f..7e240437e7d9 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -2068,7 +2068,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
  	LIST_HEAD(migratepages);
  	new_page_t *new;
  	bool compound;
-	unsigned int nr_pages = thp_nr_pages(page);
+	int nr_pages = thp_nr_pages(page);
  
  	/*
  	 * PTE mapped THP or HugeTLB page can't reach here so the page could

Already posted:

https://lkml.kernel.org/r/20210722054840.501423-1-npiggin@gmail.com

but this patch description is a lot better.


-- 
Thanks,

David / dhildenb

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help