On Jul 8, 2021, at 7:23 PM, NeilBrown [off-list ref] wrote:

On Fri, 09 Jul 2021, Chuck Lever wrote:

quoted

In this version of the series, each nfsd thread never accrues more
than 16 pages. We can easily make that larger or smaller, but 16
already reduces the rate of put_pages() calls to a minute fraction
of what it was, and does not consume much additional space in struct
svc_rqst.

Comments welcome!

Very nice.  Does "1/16" really count as "minute"? Or did I miss
something and it is actually a smaller fraction?

6% is better than an order of magnitude fewer calls. I can drop
the "minute".

Either way: excellent work.

Reviewed-by: NeilBrown <redacted>

Thanks!

NeilBrown

quoted

---

Chuck Lever (3):
     NFSD: Clean up splice actor
     SUNRPC: Add svc_rqst_replace_page() API
     NFSD: Batch release pages during splice read


fs/nfsd/vfs.c              | 20 +++++---------------
include/linux/sunrpc/svc.h |  5 +++++
net/sunrpc/svc.c           | 29 +++++++++++++++++++++++++++++
3 files changed, 39 insertions(+), 15 deletions(-)

--
Chuck Lever

--
Chuck Lever