Re: [patch 142/192] procfs: allow reading fdinfo with PTRACE_MODE_READ

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
2021-07-02 19:00:21
Also in
mm-commits
Reply to
Kees Cook, 2021-07-02
On Fri, Jul 2, 2021 at 11:43 AM Kees Cook [off-list ref] wrote:
Uhm, this is only checked in open(), and never again? Is this safe in
the face of exec or pid re-use?
Interesting question, but not really all that valid for this particular patch.

Why? Because we already only check for owner permissions on open, and
never again. So if we have fdinfo issues across a suid exec or pid
re-use, they are pre-existing..

But yes, it would probably be a good idea to think about readdir() on
that directory. If somebody reminds me after the merge window is over,
I'll come back to this, but if somebody else wants to think about it
before then, that would be great.

              Linus
Thread (212 messages) 212 messages, 11 authors, last reply 2021-07-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help