From: David Hildenbrand <redacted>
Subject: fs/proc/kcore: use page_offline_(freeze|thaw)
Let's properly synchronize with drivers that set PageOffline().
Unfreeze/thaw every now and then, so drivers that want to set
PageOffline() can make progress.
Link: https://lkml.kernel.org/r/20210526093041.8800-7-david@redhat.com (local)
Signed-off-by: David Hildenbrand <redacted>
Acked-by: Mike Rapoport <redacted>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Cc: Aili Yao <redacted>
Cc: Alexey Dobriyan <redacted>
Cc: Alex Shi <redacted>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Jason Wang <redacted>
Cc: Jiri Bohac <redacted>
Cc: "K. Y. Srinivasan" <redacted>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Kravetz <redacted>
Cc: Naoya Horiguchi <redacted>
Cc: Roman Gushchin <redacted>
Cc: Stephen Hemminger <redacted>
Cc: Steven Price <steven.price@arm.com>
Cc: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/proc/kcore.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
--- a/fs/proc/kcore.c~fs-proc-kcore-use-page_offline_freezethaw
+++ a/fs/proc/kcore.c
@@ -313,6 +313,7 @@ read_kcore(struct file *file, char __use
{
char *buf = file->private_data;
size_t phdrs_offset, notes_offset, data_offset;
+ size_t page_offline_frozen = 1;
size_t phdrs_len, notes_len;
struct kcore_list *m;
size_t tsz;@@ -322,6 +323,11 @@ read_kcore(struct file *file, char __use
int ret = 0;
down_read(&kclist_lock);
+ /*
+ * Don't race against drivers that set PageOffline() and expect no
+ * further page access.
+ */
+ page_offline_freeze();
get_kcore_size(&nphdr, &phdrs_len, ¬es_len, &data_offset);
phdrs_offset = sizeof(struct elfhdr);
@@ -480,6 +486,12 @@ read_kcore(struct file *file, char __use
}
}
+ if (page_offline_frozen++ % MAX_ORDER_NR_PAGES == 0) {
+ page_offline_thaw();
+ cond_resched();
+ page_offline_freeze();
+ }
+
if (&m->list == &kclist_head) {
if (clear_user(buffer, tsz)) {
ret = -EFAULT;@@ -565,6 +577,7 @@ skip:
}
out:
+ page_offline_thaw();
up_read(&kclist_lock);
if (ret)
return ret;
_