Thread (389 messages) flat view 389 messages, 13 authors, 2021-08-21

Re: [PATCH v14 018/138] mm/filemap: Add folio_lock()

From: Mike Rapoport <rppt@kernel.org>
Date: 2021-07-20 10:46:23
Also in: linux-fsdevel, lkml

On Thu, Jul 15, 2021 at 04:35:04AM +0100, Matthew Wilcox (Oracle) wrote:
This is like lock_page() but for use by callers who know they have a folio.
Convert __lock_page() to be __folio_lock().  This saves one call to
compound_head() per contended call to lock_page().

Saves 455 bytes of text; mostly from improved register allocation and
inlining decisions.  __folio_lock is 59 bytes while __lock_page was 79.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jeff Layton <jlayton@kernel.org>
Acked-by: Kirill A. Shutemov <redacted>
Acked-by: Vlastimil Babka <redacted>
Reviewed-by: William Kucharski <redacted>
Reviewed-by: David Howells <dhowells@redhat.com>
---
 include/linux/pagemap.h | 24 +++++++++++++++++++-----
 mm/filemap.c            | 29 +++++++++++++++--------------
 2 files changed, 34 insertions(+), 19 deletions(-)
Acked-by: Mike Rapoport <redacted>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help