Thread (389 messages) 389 messages, 13 authors, 2021-08-21

Re: [PATCH v14 020/138] mm/filemap: Add __folio_lock_async()

From: Mike Rapoport <rppt@kernel.org>
Date: 2021-07-20 10:46:08
Also in: linux-fsdevel, lkml

On Thu, Jul 15, 2021 at 04:35:06AM +0100, Matthew Wilcox (Oracle) wrote:
There aren't any actual callers of lock_page_async(), so remove it.
Convert filemap_update_page() to call __folio_lock_async().

__folio_lock_async() is 21 bytes smaller than __lock_page_async(),
but the real savings come from using a folio in filemap_update_page(),
shrinking it from 515 bytes to 404 bytes, saving 110 bytes.  The text
shrinks by 132 bytes in total.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jeff Layton <jlayton@kernel.org>
Acked-by: Kirill A. Shutemov <redacted>
Acked-by: Vlastimil Babka <redacted>
Reviewed-by: William Kucharski <redacted>
Reviewed-by: David Howells <dhowells@redhat.com>
---
 fs/io_uring.c           |  2 +-
 include/linux/pagemap.h | 17 -----------------
 mm/filemap.c            | 31 ++++++++++++++++---------------
 3 files changed, 17 insertions(+), 33 deletions(-)
Acked-by: Mike Rapoport <redacted>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help