Re: [PATCH] mm: delete unused get_kernel_page()
From: David Hildenbrand <hidden>
Date: 2021-07-30 09:17:28
Also in:
lkml
On 30.07.21 00:18, John Hubbard wrote:
get_kernel_page() was added in 2012 by [1]. It was used for a while for
NFS, but then in 2014, a refactoring [2] removed all callers, and it has
apparently not been used since.
Remove get_kernel_page() because it has no callers.
[1] commit 18022c5d8627 ("mm: add get_kernel_page[s] for pinning of
kernel addresses for I/O")
[2] commit 91f79c43d1b5 ("new helper: iov_iter_get_pages_alloc()")
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <redacted>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric B Munson <redacted>
Cc: Eric Paris <eparis@redhat.com>
Cc: James Morris <jmorris@namei.org>
Cc: Mike Christie <redacted>
Cc: Neil Brown <redacted>
Cc: Peter Zijlstra <redacted>
Cc: Sebastian Andrzej Siewior <redacted>
Cc: Trond Myklebust <redacted>
Cc: Xiaotian Feng <redacted>
Cc: Mark Salter <redacted>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
Hi,
Just a minor decluttering: I ran across this while looking for something
else entirely, and then noticed that it's been orphaned for quite a long
time. It seems like only the plural form of this function is needed
these days, and probably in the coming days as well.
thanks,
John Hubbard
NVIDIAReviewed-by: David Hildenbrand <redacted> -- Thanks, David / dhildenb