Re: [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk
From: Axel Rasmussen <axelrasmussen@google.com>
Date: 2021-07-29 17:25:59
Also in:
lkml
Reviewed-by: Axel Rasmussen <axelrasmussen@google.com> On Thu, Jul 29, 2021 at 2:28 AM Gang Li [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Ftrace core will add "\n" automatically on print. "\n" in TP_printk will create blank line, so remove it. Signed-off-by: Gang Li <redacted> --- include/trace/events/mmap_lock.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h index 0abff67b96f0..5f980c92e3e9 100644 --- a/include/trace/events/mmap_lock.h +++ b/include/trace/events/mmap_lock.h@@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking, ), TP_printk( - "mm=%p memcg_path=%s write=%s\n", + "mm=%p memcg_path=%s write=%s", __entry->mm, __get_str(memcg_path), __entry->write ? "true" : "false"@@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, ), TP_printk( - "mm=%p memcg_path=%s write=%s success=%s\n", + "mm=%p memcg_path=%s write=%s success=%s", __entry->mm, __get_str(memcg_path), __entry->write ? "true" : "false",@@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released, ), TP_printk( - "mm=%p memcg_path=%s write=%s\n", + "mm=%p memcg_path=%s write=%s", __entry->mm, __get_str(memcg_path), __entry->write ? "true" : "false" --2.20.1