Re: [PATCH -V10 2/9] mm/migrate: update node demotion order on hotplug events
From: Zi Yan <ziy@nvidia.com>
Date: 2021-07-15 18:01:00
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 854 bytes
From: Zi Yan <ziy@nvidia.com>
Date: 2021-07-15 18:01:00
Also in:
lkml
On 15 Jul 2021, at 1:51, Huang Ying wrote:
From: Dave Hansen <dave.hansen@linux.intel.com> Reclaim-based migration is attempting to optimize data placement in memory based on the system topology. If the system changes, so must the migration ordering. The implementation is conceptually simple and entirely unoptimized. On any memory or CPU hotplug events, assume that a node was added or removed and recalculate all migration targets. This ensures that the node_demotion[] array is always ready to be used in case the new reclaim mode is enabled. This recalculation is far from optimal, most glaringly that it does not even attempt to figure out the hotplug event would have some *actual* effect on the demotion order. But, given the expected paucity of hotplug events, this should be fine. Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> Signed-off-by: "Huang, Ying" <redacted> Reviewed-by: Yang Shi <redacted> Cc: Michal Hocko <mhocko@suse.com> Cc: Wei Xu <weixugc@google.com> Cc: Zi Yan <ziy@nvidia.com> Cc: osalvador <osalvador@suse.de> Cc: David Rientjes <rientjes@google.com> Cc: Dan Williams <redacted> Cc: David Hildenbrand <redacted> -- Changes since 20210618: * moved RCU part to the prev patch in series. Changes since 20210302: * remove duplicate synchronize_rcu() --- mm/migrate.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 89 insertions(+), 1 deletion(-)
LGTM. Reviewed-by: Zi Yan [off-list ref] — Best Regards, Yan, Zi