Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG
From: Yee Lee <hidden>
Date: 2021-07-05 13:53:54
Also in:
linux-arm-kernel, linux-mediatek, lkml
From: Yee Lee <hidden>
Date: 2021-07-05 13:53:54
Also in:
linux-arm-kernel, linux-mediatek, lkml
Thank you, Macro. I thought members in "suggested-by" would be put in the list as well... And thank you guys for the review these days. @Andrew Motom Hi Andrew, Could you help to push the patches? We are dealing with the issue and would backport to Android porject right after the action. Appreciated! BR, Yee On Mon, 2021-07-05 at 13:23 +0200, Andrey Konovalov wrote:
On Mon, Jul 5, 2021 at 1:18 PM Marco Elver [off-list ref] wrote:quoted
On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov <andreyknvl@gmail.comquoted
wrote:[...]quoted
quoted
+ /* + * Explicitly initialize the memory with the precise object size to + * avoid overwriting the SLAB redzone. This disables initialization in + * the arch code and may thus lead to performance penalty. The penalty + * is accepted since SLAB redzones aren't enabled in production builds. + */ + if (__slub_debug_enabled() &&What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I didn't receive patch #1 of v6 (nor of v5).Somebody had the same idea with the helper: https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com and Matthew didn't like the _unlikely() prefix. Which meant we should just move the existing helper introduced in the merge window. Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.comGot it. Thank you, Marco!