Re: [PATCH v3 05/18] mm/memcg: Convert memcg_check_events to take a node ID

[PATCH v3 00/18] Folio conversion of memcg · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
[PATCH v3 01/18] mm: Add folio_nid() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 01/18] mm: Add folio_nid() · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 02/18] mm/memcg: Remove 'page' parameter to mem_cgroup_charge_statistics() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 02/18] mm/memcg: Remove 'page' parameter to mem_cgroup_charge_statistics() · Johannes Weiner <hannes@cmpxchg.org> · 2021-06-30
[PATCH v3 03/18] mm/memcg: Use the node id in mem_cgroup_update_tree() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 03/18] mm/memcg: Use the node id in mem_cgroup_update_tree() · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 03/18] mm/memcg: Use the node id in mem_cgroup_update_tree() · Johannes Weiner <hannes@cmpxchg.org> · 2021-06-30
Re: [PATCH v3 03/18] mm/memcg: Use the node id in mem_cgroup_update_tree() · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 04/18] mm/memcg: Remove soft_limit_tree_node() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 04/18] mm/memcg: Remove soft_limit_tree_node() · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 04/18] mm/memcg: Remove soft_limit_tree_node() · Johannes Weiner <hannes@cmpxchg.org> · 2021-06-30
Re: [PATCH v3 04/18] mm/memcg: Remove soft_limit_tree_node() · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 05/18] mm/memcg: Convert memcg_check_events to take a node ID · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 05/18] mm/memcg: Convert memcg_check_events to take a node ID · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 05/18] mm/memcg: Convert memcg_check_events to take a node ID · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 05/18] mm/memcg: Convert memcg_check_events to take a node ID · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 06/18] mm/memcg: Add folio_memcg() and related functions · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 06/18] mm/memcg: Add folio_memcg() and related functions · kernel test robot <hidden> · 2021-06-30
Re: [PATCH v3 06/18] mm/memcg: Add folio_memcg() and related functions · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 07/18] mm/memcg: Convert commit_charge() to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
[PATCH v3 08/18] mm/memcg: Convert mem_cgroup_charge() to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 08/18] mm/memcg: Convert mem_cgroup_charge() to take a folio · kernel test robot <hidden> · 2021-06-30
Re: [PATCH v3 08/18] mm/memcg: Convert mem_cgroup_charge() to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 09/18] mm/memcg: Convert uncharge_page() to uncharge_folio() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 09/18] mm/memcg: Convert uncharge_page() to uncharge_folio() · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio · kernel test robot <hidden> · 2021-06-30
Re: [PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio · Christoph Hellwig <hch@infradead.org> · 2021-07-01
Re: [PATCH v3 10/18] mm/memcg: Convert mem_cgroup_uncharge() to take a folio · Matthew Wilcox <willy@infradead.org> · 2021-07-07
[PATCH v3 11/18] mm/memcg: Convert mem_cgroup_migrate() to take folios · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 11/18] mm/memcg: Convert mem_cgroup_migrate() to take folios · Christoph Hellwig <hch@infradead.org> · 2021-07-01
[PATCH v3 12/18] mm/memcg: Convert mem_cgroup_track_foreign_dirty_slowpath() to folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
[PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Matthew Wilcox <willy@infradead.org> · 2021-07-07
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Michal Hocko <mhocko@suse.com> · 2021-07-08
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Johannes Weiner <hannes@cmpxchg.org> · 2021-07-07
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Matthew Wilcox <willy@infradead.org> · 2021-07-07
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Johannes Weiner <hannes@cmpxchg.org> · 2021-07-07
Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() · Matthew Wilcox <willy@infradead.org> · 2021-07-09
[PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Matthew Wilcox <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Matthew Wilcox <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Michal Hocko <mhocko@suse.com> · 2021-06-30
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Matthew Wilcox <willy@infradead.org> · 2021-07-07
Re: [PATCH v3 14/18] mm/memcg: Convert mem_cgroup_move_account() to use a folio · Michal Hocko <mhocko@suse.com> · 2021-07-08
[PATCH v3 15/18] mm/memcg: Add mem_cgroup_folio_lruvec() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 15/18] mm/memcg: Add mem_cgroup_folio_lruvec() · kernel test robot <hidden> · 2021-06-30
Re: [PATCH v3 15/18] mm/memcg: Add mem_cgroup_folio_lruvec() · Matthew Wilcox <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 15/18] mm/memcg: Add mem_cgroup_folio_lruvec() · Johannes Weiner <hannes@cmpxchg.org> · 2021-06-30
[PATCH v3 16/18] mm/memcg: Add folio_lruvec_lock() and similar functions · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 16/18] mm/memcg: Add folio_lruvec_lock() and similar functions · Michal Hocko <mhocko@suse.com> · 2021-06-30
[PATCH v3 17/18] mm/memcg: Add folio_lruvec_relock_irq() and folio_lruvec_relock_irqsave() · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 17/18] mm/memcg: Add folio_lruvec_relock_irq() and folio_lruvec_relock_irqsave() · Michal Hocko <mhocko@suse.com> · 2021-06-30
[PATCH v3 18/18] mm/workingset: Convert workingset_activation to take a folio · "Matthew Wilcox (Oracle)" <willy@infradead.org> · 2021-06-30
Re: [PATCH v3 00/18] Folio conversion of memcg · Michal Hocko <mhocko@suse.com> · 2021-06-30

From: Michal Hocko <mhocko@suse.com>
Date: 2021-06-30 06:59:23
Also in: cgroups

On Wed 30-06-21 08:58:20, Michal Hocko wrote:

On Wed 30-06-21 05:00:21, Matthew Wilcox wrote:

quoted

memcg_check_events only uses the page's nid, so call page_to_nid in the
callers to make the folio conversion easier.

It will also make the interface slightly easier to follow as there
shouldn't be any real reason to take the page for these events.
So this is a good cleanup in general.

quoted

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Acked-by: Michal Hocko <mhocko@suse.com>

Btw. patches 2-5 seem good enough to go to Andrew even without the rest
so that you do not have to carry them along with the rest which is quite
large I can imagine.
-- 
Michal Hocko
SUSE Labs

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help