Thread (2 messages) 2 messages, 2 authors, 2021-06-29

Re: [PATCH] kfence: skip DMA allocations

From: Marco Elver <elver@google.com>
Date: 2021-06-29 13:05:21
Also in: lkml, stable

On Tue, 29 Jun 2021 at 15:00, Alexander Potapenko [off-list ref] wrote:
[...]
+       /*
+        * Skip DMA allocations. These must reside in the low memory, which we
+        * cannot guarantee.
+        */
+       if (flags & (__GFP_DMA | __GFP_DMA32) ||
I think we want braces around "flags & (...)", so that this becomes:

    if ((flags & (...)) ||
+           (s->flags & (SLAB_CACHE_DMA | SLAB_CACHE_DMA32)))
+               return NULL;
Thanks,
-- Marco
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help