Re: [PATCH 6/6] mm/z3fold: use release_z3fold_page_locked() to release locked z3fold page

From
Miaohe Lin <linmiaohe@huawei.com>
Date
2021-06-22 13:49:42
Also in
lkml
Reply to
Hillf Danton, 2021-06-20
On 2021/6/20 8:26, Hillf Danton wrote:
On Sat, 19 Jun 2021 17:31:51 +0800 Miaohe Lin wrote:
quoted
We should use release_z3fold_page_locked() to release z3fold page when it's
locked, although it looks harmless to use release_z3fold_page() now.

Fixes: dcf5aedb24f8 ("z3fold: stricter locking and more careful reclaim")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/z3fold.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/z3fold.c b/mm/z3fold.c
index 196d886a3436..b3c0577b8095 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -1372,7 +1372,7 @@ static int z3fold_reclaim_page(struct z3fold_pool *pool, unsigned int retries)
 			if (zhdr->foreign_handles ||
 			    test_and_set_bit(PAGE_CLAIMED, &page->private)) {
 				if (kref_put(&zhdr->refcount,
-						release_z3fold_page))
+						release_z3fold_page_locked))
 					atomic64_dec(&pool->pages_nr);
LGTM. JFYI other issue in z3fold was reported [1] and if the fix proposed there
makes any sense to you feel free to pick it up and ask Mike for his tests.
Thank you for review and reply.

I browsed [1] several times but I failed to figure out what's the root cause. And I found
some bugs and possible race windows from previous code inspection. I think we can try fix
these first and see whether [1] is (hopefully) fixed. :)
Thanks again.
[1] https://lore.kernel.org/linux-mm/20210316061351.1649-1-hdanton@sina.com/ (local)
.
  
Thread (10 messages) 10 messages, 3 authors, last reply 2021-06-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help