Re: [PATCH v2 08/10] mm: rmap: make try_to_unmap() void function

From
HORIGUCHI NAOYA (堀口 直也) <hidden>
Date
2021-06-10 07:57:32
Also in
lkml
Reply to
Hugh Dickins, 2021-06-09
On Tue, Jun 08, 2021 at 09:25:22PM -0700, Hugh Dickins wrote:
From: Yang Shi <redacted>

Currently try_to_unmap() return bool value by checking page_mapcount(),
however this may return false positive since page_mapcount() doesn't
check all subpages of compound page.  The total_mapcount() could be used
instead, but its cost is higher since it traverses all subpages.

Actually the most callers of try_to_unmap() don't care about the
return value at all.  So just need check if page is still mapped by
page_mapped() when necessary.  And page_mapped() does bail out early
when it finds mapped subpage.

Suggested-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Yang Shi <redacted>
Acked-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Shakeel Butt <redacted>
Acked-by: Kirill A. Shutemov <redacted>
Signed-off-by: Hugh Dickins <hughd@google.com>
Looks good to me, thank you.

Acked-by: Naoya Horiguchi <redacted>
Thread (2 messages) 2 messages, 2 authors, last reply 2021-06-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help