Thread (12 messages) 12 messages, 4 authors, 2021-06-07

Re: [PATCH] mm, hugetlb: fix allocation error check and copy func name

From: Mike Kravetz <hidden>
Date: 2021-06-07 20:32:46
Also in: lkml

On 6/4/21 6:06 PM, Mina Almasry wrote:
The alloc_huge_page_vma() doesn't return error pointers, it returns
NULL.

There is an existing migrate_page_copy() which not only copies the page
contents, but also page state/metadata.  People could get confused that
'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same
functionality.  Rename to 'copy_huge_page()' to make it less likely
folks get confused.

Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on
UFFDIO_COPY")

Signed-off-by: Mina Almasry <redacted>
Cc: linux-mm@kvack.org
Cc: Mike Kravetz <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org

---
 include/linux/migrate.h | 4 ++--
 mm/hugetlb.c            | 4 ++--
 mm/migrate.c            | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
As mentioned by Muchun, Andrew should squash this and original patch.
With the combined patches,

Reviewed-by: Mike Kravetz <redacted>
-- 
Mike Kravetz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help