Thread (4 messages) 4 messages, 3 authors, 2021-06-01

Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2021-05-31 22:05:59
Also in: oe-kbuild-all

On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman [off-list ref] wrote:
On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
quoted
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
config: x86_64-randconfig-a006-20210530 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
Hi Andrew,

Can you please drop the patch
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?
Didn't I fix this with
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch?

This fix is lame - x86's fixmap.h should be standalone.  But this gets us
moving ahead with the MM changes for now.



From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix

x86_64 asm/fixmap.h needs linux/threads.h for NR_CPUS

Cc: Dan Streetman <redacted>
Cc: David Hildenbrand <redacted>
Cc: Mel Gorman <redacted>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <redacted>
Cc: Yang Shi <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/asm-generic/early_ioremap.h |    1 +
 1 file changed, 1 insertion(+)
--- a/include/asm-generic/early_ioremap.h~mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix
+++ a/include/asm-generic/early_ioremap.h
@@ -3,6 +3,7 @@
 #define _ASM_EARLY_IOREMAP_H_
 
 #include <linux/types.h>
+#include <linux/threads.h>	/* x86 fixmap.h needs NR_CPUS */
 #include <asm/fixmap.h>
 
 /*
_

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help