Re: [PATCH v3 2/2] secretmem: optimize page_is_secretmem()
From: rppt@kernel.org
Date: 2021-05-08 17:51:36
[off-list ref],Shuah Khan [off-list ref],Thomas Gleixner [off-list ref],Tycho Andersen [off-list ref],Will Deacon [off-list ref],Yury Norov [off-list ref],linux-api@vger.kernel.org,linux-arch@vger.kernel.org,linux-arm-kernel@lists.infradead.org,linux-fsdevel@vger.kernel.org,linux-mm@kvack.org,linux-kernel@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-nvdimm@lists.01.org,linux-riscv@lists.infradead.org,x86@kernel.org,kernel test robot [off-list ref] From: Mike Rapoport <rppt@kernel.org> Message-ID: [off-list ref] On May 7, 2021 6:01:44 PM GMT+03:00, Matthew Wilcox [off-list ref] wrote:
On Tue, Apr 20, 2021 at 06:00:49PM +0300, Mike Rapoport wrote:quoted
+ mapping = (struct address_space *) + ((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS); + + if (mapping != page->mapping) + return false; + + return page->mapping->a_ops == &secretmem_aops;... why do you go back to page->mapping here? return mapping->a_ops == &secretmem_aops
Ok -- Sincerely yours, Mike