Thread (81 messages) 81 messages, 6 authors, 2021-05-11

Re: [PATCH 01/16] PCI/P2PDMA: Pass gfp_mask flags to upstream_bridge_distance_warn()

From: Christoph Hellwig <hch@lst.de>
Date: 2021-05-03 18:24:44
Also in: linux-block, linux-iommu, linux-nvme, linux-pci, lkml

On Mon, May 03, 2021 at 11:17:31AM -0700, John Hubbard wrote:
That's the thing: memory failure should be exceedingly rare for this.
Therefore, just fail out entirely (which I don't expect we'll likely
ever see), instead of doing all this weird stuff to try to continue
on if you cannot allocate a single page. If you are in that case, the
system is not in a state that is going to run your dma p2p setup well
anyway.

I think it's *less* complexity to allocate up front, fail early if
allocation fails, and then not have to deal with these really odd
quirks at the lower levels.
Agreed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help