Re: [PATCH v10 32/33] fs/netfs: Add folio fscache functions
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-05-27 08:24:15
Also in:
linux-fsdevel, lkml
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-05-27 08:24:15
Also in:
linux-fsdevel, lkml
On Tue, May 11, 2021 at 10:47:34PM +0100, Matthew Wilcox (Oracle) wrote:
Match the page writeback functions by adding folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and folio_wait_fscache_killable(). Also rewrite the kernel-doc to describe when to use the function rather than what the function does, and include the kernel-doc in the appropriate rst file. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks fine, but doesn't actually seem to be needed for this series. I'd move it closer to actual users of the new helpers. Otherwise: Reviewed-by: Christoph Hellwig <hch@lst.de>