Thread (20 messages) 20 messages, 2 authors, 2021-05-12
STALE1858d
Revisions (6)
  1. v1 current
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v4 [diff vs current]
  5. v5 [diff vs current]
  6. v6 [diff vs current]

[PATCH 13/17] mm: workingset: allocate list_lru on xa_node allocation

From: Muchun Song <hidden>
Date: 2021-05-11 10:52:56
Also in: linux-fsdevel, linux-nfs, lkml
Subsystem: memory management, memory management - mglru (multi-gen lru), memory management - reclaim, memory management - swap, the rest · Maintainers: Andrew Morton, Johannes Weiner, Chris Li, Kairui Song, Linus Torvalds

The workingset will add the xa_node to its list_lru, we should use
xas_set_lru() to pass which lru we want to insert.

Signed-off-by: Muchun Song <redacted>
---
 include/linux/swap.h | 5 ++++-
 mm/workingset.c      | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/linux/swap.h b/include/linux/swap.h
index 144727041e78..a2418ebad13d 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -322,9 +322,12 @@ void workingset_activation(struct page *page);
 
 /* Only track the nodes of mappings with shadow entries */
 void workingset_update_node(struct xa_node *node);
+extern struct list_lru shadow_nodes;
 #define mapping_set_update(xas, mapping) do {				\
-	if (!dax_mapping(mapping) && !shmem_mapping(mapping))		\
+	if (!dax_mapping(mapping) && !shmem_mapping(mapping)) {		\
 		xas_set_update(xas, workingset_update_node);		\
+		xas_set_lru(xas, &shadow_nodes);			\
+	}								\
 } while (0)
 
 /* linux/mm/page_alloc.c */
diff --git a/mm/workingset.c b/mm/workingset.c
index b7cdeca5a76d..f6923865be47 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -426,7 +426,7 @@ void workingset_activation(struct page *page)
  * point where they would still be useful.
  */
 
-static struct list_lru shadow_nodes;
+struct list_lru shadow_nodes;
 
 void workingset_update_node(struct xa_node *node)
 {
-- 
2.11.0

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help