Thread (27 messages) 27 messages, 8 authors, 2021-06-02
STALE1876d
Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH V2 1/6] mm: drop SECTION_SHIFT in code comments

From: Dong Aisheng <aisheng.dong@nxp.com>
Date: 2021-05-31 09:20:35
Also in: lkml
Subsystem: memory management - core, memory management - mglru (multi-gen lru), the rest · Maintainers: Andrew Morton, David Hildenbrand, Linus Torvalds

Actually SECTIONS_SHIFT is used in the kernel code, so the code
comments is strictly incorrect. And since
commit bbeae5b05ef6 ("mm: move page flags layout to separate header"),
SECTIONS_SHIFT definition has been moved to include/linux/page-flags-layout.h,
since code itself looks quite straighforward, instead of moving
the code comment into the new place as well, we just simply remove it.

This also fixed a checkpatch complain derived from the original code:
WARNING: please, no space before tabs
+ * SECTIONS_SHIFT    ^I^I#bits space required to store a section #$

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Yu Zhao <redacted>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Kees Cook <redacted>
Suggested-by: Yu Zhao <redacted>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
Changelog:
v1->v2:
 * drop the SECTION_SHIFT code comments instead of moving it
---
 include/linux/mmzone.h | 2 --
 1 file changed, 2 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 05cbcddbf432..a6bfde85ddb0 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1203,8 +1203,6 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
 #ifdef CONFIG_SPARSEMEM
 
 /*
- * SECTION_SHIFT    		#bits space required to store a section #
- *
  * PA_SECTION_SHIFT		physical address to/from section number
  * PFN_SECTION_SHIFT		pfn to/from section number
  */
-- 
2.25.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help