Re: [PATCH 23/94] radix tree test suite: Add support for kmem_cache_free_bulk
From: Suren Baghdasaryan <surenb@google.com>
Date: 2021-05-28 17:56:22
Also in:
lkml
On Wed, Apr 28, 2021 at 8:36 AM Liam Howlett [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Liam R. Howlett <redacted> --- tools/testing/radix-tree/linux.c | 9 +++++++++ tools/testing/radix-tree/linux/slab.h | 1 + 2 files changed, 10 insertions(+)diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/radix-tree/linux.c index 93f7de81fbe8..380bbc0a48d6 100644 --- a/tools/testing/radix-tree/linux.c +++ b/tools/testing/radix-tree/linux.c@@ -91,6 +91,15 @@ void kmem_cache_free(struct kmem_cache *cachep, void *objp) pthread_mutex_unlock(&cachep->lock); } +void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t size, void **list) +{ + if (kmalloc_verbose) + printk("Bulk free %p[0-%lu]\n", list, size - 1);
nit: Printing the address of the "list" is meaningless IMHO unless you output its value in kmem_cache_alloc_bulk, which you do not. I would also suggest combining the patch introducing kmem_cache_alloc_bulk with this one since they seem to be compementary.
quoted hunk ↗ jump to hunk
+ + for (int i = 0; i < size; i++) + kmem_cache_free(cachep, list[i]); +} + void *kmalloc(size_t size, gfp_t gfp) { void *ret;diff --git a/tools/testing/radix-tree/linux/slab.h b/tools/testing/radix-tree/linux/slab.h index 2958830ce4d7..53b79c15b3a2 100644 --- a/tools/testing/radix-tree/linux/slab.h +++ b/tools/testing/radix-tree/linux/slab.h@@ -24,4 +24,5 @@ struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, unsigned int align, unsigned int flags, void (*ctor)(void *)); +void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t, void **); #endif /* SLAB_H */ --2.30.2