Re: [PATCH 3/3] slub: Actually use 'message' in restore_bytes()
From: Vlastimil Babka <hidden>
Date: 2021-05-20 10:08:50
Also in:
lkml
On 5/20/21 3:35 AM, Stephen Boyd wrote:
The message argument isn't used here. Let's pass the string to the printk message so that the developer can figure out what's happening, instead of guessing that a redzone is being restored, etc. Signed-off-by: Stephen Boyd <redacted>
Reviewed-by: Vlastimil Babka <redacted>
quoted hunk ↗ jump to hunk
--- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/mm/slub.c b/mm/slub.c index 87eeeed1f369..16e8e8f8dc0c 100644 --- a/mm/slub.c +++ b/mm/slub.c@@ -777,7 +777,7 @@ static void init_object(struct kmem_cache *s, void *object, u8 val) static void restore_bytes(struct kmem_cache *s, char *message, u8 data, void *from, void *to) { - slab_fix(s, "Restoring 0x%px-0x%px=0x%x\n", from, to - 1, data); + slab_fix(s, "Restoring %s 0x%px-0x%px=0x%x\n", message, from, to - 1, data); memset(from, data, to - from); }