Re: [PATCH v3 4/5] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
From: Oscar Salvador <osalvador@suse.de>
Date: 2021-03-07 22:15:48
Also in:
lkml
Subsystem:
memory management, memory management - core, the rest, x86 architecture (32-bit and 64-bit) · Maintainers:
Andrew Morton, David Hildenbrand, Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
On Fri, Mar 05, 2021 at 04:32:07PM +0100, David Hildenbrand wrote:
On 04.03.21 11:00, Oscar Salvador wrote:quoted
Enable x86_64 platform to use the MHP_MEMMAP_ON_MEMORY feature. Signed-off-by: Oscar Salvador <osalvador@suse.de> --- arch/x86/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 2792879d398e..6d716d8bce1e 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig@@ -2433,6 +2433,10 @@ config ARCH_ENABLE_MEMORY_HOTREMOVE def_bool y depends on MEMORY_HOTPLUG +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE + def_bool y + depends on X86_64 && MEMORY_HOTPLUGWas wondering if the MEMORY_HOTPLUG would also best be part of the generic MHP_MEMMAP_ON_MEMORY.
Yes, I think it suits best in the generic Kconfig. Something like this on top of patch#1:
diff --git a/mm/Kconfig b/mm/Kconfig
index de3a7b5ed216..febf805000f8 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig@@ -185,7 +185,8 @@ config MEMORY_HOTREMOVE config MHP_MEMMAP_ON_MEMORY def_bool y - depends on SPARSEMEM_VMEMMAP && ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE + depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP + depends on ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
And then this patch would be:
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 2792879d398e..9f0211df1746 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig@@ -2433,6 +2433,9 @@ config ARCH_ENABLE_MEMORY_HOTREMOVE def_bool y depends on MEMORY_HOTPLUG +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE + def_bool y
because MEMORY_HOTPLUG already depends on 64 bits. And the same would go for the arm64 one. Better? -- Oscar Salvador SUSE L3