Re: [RFC PATCH 1/4] Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()"
From: Matthew Wilcox <willy@infradead.org>
Date: 2021-03-23 20:17:07
Also in:
linux-fsdevel, lkml
From: Matthew Wilcox <willy@infradead.org>
Date: 2021-03-23 20:17:07
Also in:
linux-fsdevel, lkml
On Tue, Mar 23, 2021 at 04:59:38PM -0300, André Almeida wrote:
This reverts commit 794c43f716845e2d48ce195ed5c4179a4e05ce5f. For implementing casefolding support at tmpfs, it needs to set dentry operations at superblock level, given that tmpfs has no support for fscrypt and we don't need to set operations on a per-dentry basis. Revert this commit so we can access those exported function from tmpfs code.
But tmpfs / shmem are Kconfig bools, not tristate. They can't be built as modules, so there's no need to export the symbols.
+#ifdef CONFIG_UNICODE +extern int generic_ci_d_hash(const struct dentry *dentry, struct qstr *str); +extern int generic_ci_d_compare(const struct dentry *dentry, unsigned int len, + const char *str, const struct qstr *name); +#endif
There's no need for the ifdef (it only causes unnecessary rebuilds) and the 'extern' keyword is also unwelcome.