[patch 097/118] lib/cmdline: remove an unneeded local variable in next_arg()
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2021-02-26 01:21:38
Also in:
mm-commits
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2021-02-26 01:21:38
Also in:
mm-commits
From: Masahiro Yamada <masahiroy@kernel.org> Subject: lib/cmdline: remove an unneeded local variable in next_arg() The local variable 'next' is unneeded because you can simply advance the existing pointer 'args'. Link: https://lkml.kernel.org/r/20210201014707.3828753-1-masahiroy@kernel.org Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- lib/cmdline.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
--- a/lib/cmdline.c~lib-cmdline-remove-an-unneeded-local-variable-in-next_arg
+++ a/lib/cmdline.c@@ -228,7 +228,6 @@ char *next_arg(char *args, char **param, { unsigned int i, equals = 0; int in_quote = 0, quoted = 0; - char *next; if (*args == '"') { args++;
@@ -266,10 +265,10 @@ char *next_arg(char *args, char **param, if (args[i]) { args[i] = '\0'; - next = args + i + 1; + args += i + 1; } else - next = args + i; + args += i; /* Chew up trailing spaces. */ - return skip_spaces(next); + return skip_spaces(args); }
_